Question service tests completed and passing #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it and the concurrency problem was still happening, so I solved it making some modifications to the answer endpoint. |
|
Thanks for solving it, Christian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I corrected the test cases and some minor bugs there were in question-service.js.
Regarding #84, I thought initially that tests were not passing due to the async tests behaving as concurrent users and my approach of answer storing not being adequate for it, but once I corrected those mistakes now they all pass.
I have to investigate more but it is possible that the global variable 'correctImage' in question-service.js is unique per session, so there should be no collision between different users in reallity and question-service should thus be complete (That is what I infered from the results of the async tests, which I ran multiple times).